Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1781 Rails update to 7.2.1 #1604

Merged
merged 3 commits into from
Oct 21, 2024
Merged

EL-1781 Rails update to 7.2.1 #1604

merged 3 commits into from
Oct 21, 2024

Conversation

willc-work
Copy link
Contributor

@willc-work willc-work commented Oct 16, 2024

Jira ticket

What changed and why

update rails version to 7.2.1
add ORM specific databasse cleaner gem because the original gem is no longer compatible with rails >=7.2
the alias_attribute method has been partly deprecated, unfortunately the part that was deprecated was the feature we were using. Replaced with alias_method

https://guides.rubyonrails.org/7_2_release_notes.html
from changelog:
Remove deprecated support to call alias_attribute with non-existent attribute names.

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@willc-work willc-work changed the title EL-1781 dep rails EL-1781 Rails update to 7.2.1 Oct 16, 2024
@willc-work willc-work marked this pull request as ready for review October 16, 2024 12:09
@willc-work willc-work requested a review from a team as a code owner October 16, 2024 12:09
@willc-work willc-work added the UAT Keep PR open to keep ephemeral UAT URL alive label Oct 16, 2024
@HettieS HettieS merged commit 58053cd into main Oct 21, 2024
12 checks passed
@HettieS HettieS deleted the EL-1781-dep-rails branch October 21, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants